Feature/whats new #19
Conversation
There was a problem hiding this comment.
Left a few minor comments. Also - can you raise this PR into gh-pages branch instead? feature/whatsNew was a feature we started but never finalized + never merged (it's not ready to merge).
You can create your own feature branch from gh-pages (call it say, feature/jamesChanges, or whatever), and merge into gh-pages. Thanks!
| layout: default | ||
| title: Best Practices | ||
| nav_order: 4 | ||
| parent: GraphQL Concepts |
There was a problem hiding this comment.
Just want to clarify, do you want this under GraphQL Concepts, or under FAQ?
If we want it under GraphQL Concepts, can we just move this file into the directory graphql-concepts/ (just for organization)? It's currently in the faq/ dir.
There was a problem hiding this comment.
Let's move it under FAQ, makes most sense to me
| Instead of specifying a list of field names we recommend creating a fragment as a best practice once and reuse it everywhere. This makes your queries modular and easy to understand. [Read more about fragments here](../../graphql-concepts/other-concepts/#fragments) | ||
|
|
||
|
|
||
| ## Error Handling |
There was a problem hiding this comment.
I assume the intent was to remove Error Handling from this page (into its own page), right? We should remove it from here.
There was a problem hiding this comment.
Yes, was trying to move it, sorry!
| parent: GraphQL Concepts | ||
| --- | ||
|
|
||
| ## Best Practices |
There was a problem hiding this comment.
Ditto as above, should remove this top section (Best Practices), and leave only Error Handling bottom section (assuming that was the intent here)
| parent: GraphQL Concepts | ||
| --- | ||
|
|
||
| ## Best Practices |
There was a problem hiding this comment.
Ditto as above, should remove this top section (Best Practices), and leave only Error Handling bottom section (assuming that was the intent here)
There was a problem hiding this comment.
Was trying to create two separate pages, one for errors and one for best practices - sorry I am still learning this
James' updates