Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 7 support #29

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Symfony 7 support #29

merged 1 commit into from
Dec 29, 2023

Conversation

IonBazan
Copy link
Owner

@IonBazan IonBazan commented Dec 29, 2023

As Symfony 7 adds return types to Commands which is a breaking change. To mitigate this, I did some hacks in order to maintain compatibility with both PHP 5.3 and older versions of Symfony by adding two base command variants and a conditional alias 🤮

Note: This only affects people using this library as a binary (vendor/bin/composer-diff) in a project where composer/composer and symfony/console are installed as dependencies. You can still use it as a Composer plugin (composer diff) with any version of Symfony without upgrading.

Doesn't look nice but works like a charm (see tests)

@IonBazan IonBazan self-assigned this Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7482e1f) 100.00% compared to head (005967f) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##                main       #29   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       206       206           
===========================================
  Files             19        19           
  Lines            596       610   +14     
===========================================
+ Hits             596       610   +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IonBazan IonBazan merged commit 57c9f41 into main Dec 29, 2023
38 checks passed
@IonBazan IonBazan deleted the feature/symfony-7 branch December 29, 2023 08:46
@IonBazan IonBazan added the enhancement New feature or request label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant