The "Node has ancestor" condition shouldn't be required (#867)

Islandora · Apr 19, 2022 · a04a72c · a04a72c
1 parent e0152ea
commit a04a72c
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/Plugin/Condition/NodeHasAncestor.php b/src/Plugin/Condition/NodeHasAncestor.php
@@ -96,7 +96,7 @@ public function buildConfigurationForm(array $form, FormStateInterface $form_sta
       '#type' => 'entity_autocomplete',
       '#title' => $this->t('Parent node(s)'),
       '#default_value' => $default_nids,
-      '#required' => TRUE,
+      '#required' => FALSE,
       '#description' => $this->t("Can be a collection node, compound object or paged content. Accepts multiple values separated by a comma."),
       '#target_type' => 'node',
       '#tags' => TRUE,
@@ -130,9 +130,11 @@ public function buildConfigurationForm(array $form, FormStateInterface $form_sta
   public function submitConfigurationForm(array &$form, FormStateInterface $form_state) {
     // Entity autocomplete store things with target IDs, for convenience just
     // store the plain nid.
-    $this->configuration['ancestor_nids'] = array_map(function ($nid) {
-      return $nid['target_id'];
-    }, $form_state->getValue('ancestor_nids'));
+    if (!empty($form_state->getValue('ancestor_nids'))) {
+      $this->configuration['ancestor_nids'] = array_map(function ($nid) {
+        return $nid['target_id'];
+      }, $form_state->getValue('ancestor_nids'));
+    }
     $this->configuration['parent_reference_field'] = $form_state->getValue('parent_reference_field');
     parent::submitConfigurationForm($form, $form_state);
   }