Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of Fortran copy of field data, part 2 #1129

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from

Conversation

travissluka
Copy link
Collaborator

Description

Part 2 of 3 to address

Like the previous PR, lots of places in Increment, State, Fields, and Soca2Cice have been refactored to use the field data stored in the atlas fieldset instead of the Fortran field%val.

This leaves just 3 places in State and Increment (The constructor, read, and write) where code needs to be refactored to use the atlas fieldset.

1 more PRs after this before we can remove the Fortran-only internal field data and free up some memory!

Testing

There are no changes in any answers.

I also tested with the 1/4 deg, 1/2 deg minimization on my computer, 24 cores, there are no changes in answers and runtime for Increment::operator= in particular is faster

develop branch

OOPS_STATS Name                                                :   total (ms)   count    time/call (ms)
OOPS_STATS oops::Increment::operator=                          :      6114.75      50          122.2950
OOPS_STATS oops::State::State                                  :     20990.21      12         1749.1840
OOPS_STATS util::Timers::measured                              :    177209.59       1       177209.5908

this PR

OOPS_STATS Name                                                :   total (ms)   count    time/call (ms)
OOPS_STATS oops::Increment::operator=                          :      1097.81      50           21.9562
OOPS_STATS oops::State::State                                  :     17529.44      12         1460.7867
OOPS_STATS util::Timers::measured                              :    174685.07       1       174685.0693

@travissluka travissluka added the SOCA Sea-ice, Ocean, and Coupled Assimilation label Jan 24, 2025
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SOCA Sea-ice, Ocean, and Coupled Assimilation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants