-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of Fortran copy of field data, part 2 #1129
Open
travissluka
wants to merge
23
commits into
develop
Choose a base branch
from
feature/rm_fortran_field_part2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nc calls and improve cleanup_ice functionality
…emove Fortran interfaces
… with C++ implementations
guillaumevernieres
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part 2 of 3 to address
Like the previous PR, lots of places in
Increment
,State
,Fields
, andSoca2Cice
have been refactored to use the field data stored in the atlas fieldset instead of the Fortranfield%val
.This leaves just 3 places in
State
andIncrement
(The constructor, read, and write) where code needs to be refactored to use the atlas fieldset.1 more PRs after this before we can remove the Fortran-only internal field data and free up some memory!
Testing
There are no changes in any answers.
I also tested with the 1/4 deg, 1/2 deg minimization on my computer, 24 cores, there are no changes in answers and runtime for
Increment::operator=
in particular is fasterdevelop branch
this PR