-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing CI tests (CRTM cmake errors) and remove dependency on w3nco
#48
Conversation
@climbfuji can you explain in a few words why this only affects ufs-bundle but not jedi-bundle? (or does it also affect jedi-bundle?) |
I can: I have no idea. But I assume it's because of the way we build the code - that whole mix and match of ecbuild packages for most packages, plain cmake for crtm, cmake external project for ufs-weather-model, is a fragile configuration. Going back to the release tag where crtm was an ecbuild package works. In jedi-bundle, we don't have all of that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@climbfuji sounds good to me, thank you!
Description
v3.1.0-skylabv7
for CRTM until problems with recently introduced plaincmake
build are resolvedw3nco
(replaced byw3emc
); for more details see associated PR https://github.com/JCSDA-internal/fv3-jedi/pull/1127Note. Once https://github.com/JCSDA-internal/fv3-jedi/pull/1127 is merged, need to revert the temporary branch name change for
fv3-jedi
Issue(s) addressed
Resolves failing CI tests
This is a workaround for #49 (not a solution)
Dependencies
Impact
n/a
Checklist