Updates to the PCIe interface to allow for shared control signals #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the pcie bundle definitions and adds a new set of helper functions for creating pcie-based bundles. The user will likely want to use `pcie-std()` instead of `pcie()` to make pcie bundles.
bhusang
approved these changes
Jan 23, 2025
| ] | ||
|
|
||
| for btype in bundle-types do: | ||
| connect_lanes(btype) |
There was a problem hiding this comment.
Oh, neat way to reduce typing.
| @@ -168,29 +168,58 @@ public pcb-module module : | |||
| bd-4x-prsnt.control.PRSNT# => sw.GPIO[12] | |||
| bd-4x-prsnt.control.CLKREQ# => sw.GPIO[1] | |||
|
|
|||
| ; For the PCIe-2X, I'm going to demonstrate | |||
| ; how to use a shared port WAKE pin across | |||
| ; the different. This is common situation where | |||
There was a problem hiding this comment.
the different. => the different endpoints.
src/protocols/pcie.stanza
Outdated
| PCIe-PRSNT# : make-port(`PRSNT#) ; hot plug detection | ||
| PCIe-WAKE# : make-port(`PEWAKE#) | ||
| PCIe-PERST# : make-port(`PERST#) ; PCI-E Reset signal | ||
| PCIe-CLKREQ# : ,make-port(`CLKREQ#) ; clock request |
Johnsel
reviewed
Jan 24, 2025
|
|
||
| inst dut1 : jsl/examples/protocols/pcie/pcie-src/module | ||
| inst dut2 : jsl/examples/protocols/pcie/pcie-conn/module | ||
| inst dut3 : jsl/examples/protocols/pcie/pcie-conn/module |
There was a problem hiding this comment.
dut3 not used? likely intended to be inst dut2 : jsl/examples/protocols/pcie/pcie-conn/module[2]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the pcie bundle definitions and adds a new set of helper functions for creating pcie-based bundles. The user will likely want to use
pcie-std()instead ofpcie()to make pcie bundles. All control pins are not optional to allow for the user to share control pin functionality across multiple pin-assigned ports. This is likely going to be a common pattern in other connectors I would guess.This also adds a new PCIe example that uses a shared wake pin with fanout to multiple connectors.
@Johnsel - FYI - here is the example I mentioned in discord. Still rats nest issues but this should work and not require additional jumper resistor components.