Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to dp-coupler for non-JSL 2-pin landpatterns #235

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

callendorph
Copy link
Contributor

In the previous implementation

  inst tx-coupler : dp-coupler(
    create-part(
      mpn = "ESD132-B1-W0201 E6327", 
      manufacturer = "Infineon"
    )
  )

Results in something like this:

Screenshot 2025-01-23 at 3 16 32 PM

because the parts-DB landpattern for this part is rotated 90 degrees from the JSL 2-pin standard landpattern.

This PR adds a new pre-pose argument that allows for the components in the dp-coupler to be oriented before being constructed in the coupler form.

  inst tx-coupler : dp-coupler(
    create-part(
      mpn = "ESD132-B1-W0201 E6327", 
      manufacturer = "Infineon"
    ),
    pre-pose = loc(0.0, 0.0, 90.0)
  )
Screenshot 2025-01-23 at 3 18 47 PM

@Johnsel - FYI

This allows for components used in `dp-coupler` to be pre-rotated
if they are not aligned as expected of JSL 2-pin landpatterns
@callendorph callendorph requested a review from bhusang January 23, 2025 23:20
@Johnsel
Copy link

Johnsel commented Jan 23, 2025

Thank you for accomodating a fix for this issue so quickly! :)

@callendorph callendorph merged commit 1639834 into main Jan 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants