(chocolatey#66) Fixes Get-CCMComputer Matching Names

Unless we intended to provide regex-matching functionality here (which isn't obvious from the help), this fixes the ability to return multiple computers with a single name (or even random regex query).
JPRuskin · May 6, 2023 · 98f3180 · 98f3180
1 parent 4a05bdb
commit 98f3180
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/Public/Get-CCMComputer.ps1 b/src/Public/Get-CCMComputer.ps1
@@ -49,7 +49,7 @@ function Get-CCMComputer {
         switch ($PSCmdlet.ParameterSetName) {
             "Computer" {
                 foreach ($c in $computer) {
-                    [pscustomobject]$records.result | Where-Object { $_.name -match "$c" }
+                    [pscustomobject]$records.result | Where-Object { $_.name -eq $c }
                 }
             }
             "Id" {

diff --git a/src/Tests/Public/Get-CCMComputer.Tests.ps1 b/src/Tests/Public/Get-CCMComputer.Tests.ps1
@@ -11,7 +11,7 @@ Describe "Get-CCMComputer" {
             $Uri.AbsolutePath -eq "/api/services/app/Computers/GetAll"
         } {
             @{
-                result =  1..9 | ForEach-Object {
+                result =  1..20 | ForEach-Object {
                     [PSCustomObject]@{
                         name = "Computer $_"
                     }
@@ -41,7 +41,7 @@ Describe "Get-CCMComputer" {
         }
 
         It "Returns All Computers" {
-            $Result | Should -HaveCount 9
+            $Result | Should -HaveCount 20
         }
     }
 
@@ -68,9 +68,7 @@ Describe "Get-CCMComputer" {
     Context "Getting computers by Name" {
         BeforeAll {
             $TestParams = @{
-                # This test fails when Computer 1 and Computer 10 are both selected, due to the naive match
-                Computer = 1..9 | Get-Random -Count (Get-Random -Minimum 1 -Maximum 9) | ForEach-Object { "Computer $($_)" }
-                # Computer = 1..10 | Get-Random -Count (Get-Random -Minimum 1 -Maximum 10) | ForEach-Object { "Computer $($_)" }
+                Computer = 1..10 | Get-Random -Count (Get-Random -Minimum 1 -Maximum 10) | ForEach-Object { "Computer $($_)" }
             }
             $Result = Get-CCMComputer @TestParams
         }