Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix focus and keybinding in search #3182

Merged
merged 2 commits into from
Sep 3, 2017
Merged

Fix focus and keybinding in search #3182

merged 2 commits into from
Sep 3, 2017

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Sep 1, 2017 •
edited
Loading

Fix #3081
Arrow keys (left, right, up and down no work as expected and the up/down + Enter can be used to select an entry from the autocomplete menu)

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 1, 2017
@Siedlerchr Siedlerchr added this to the v4.0 milestone Sep 1, 2017
lenhard
lenhard approved these changes Sep 1, 2017
View reviewed changes
Copy link
Member

@lenhard lenhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works. Good job!

The constructor in GlobalSearchBar is already really huge. Could you maybe extract the KeyAdapter which you extended here into an inner class instead of an anonymous class, just to reduce size a little?

@Siedlerchr
Copy link
Member Author

done

@koppor koppor merged commit b701a57 into master Sep 3, 2017
@koppor koppor deleted the searchFocusKeybindings branch September 3, 2017 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenhard lenhard lenhard approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Siedlerchr @lenhard @koppor