Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite EndnoteXMLImporter as a StAX-Parser #9880

Merged
merged 14 commits into from
May 20, 2023
Merged

Rewrite EndnoteXMLImporter as a StAX-Parser #9880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
dfa759e
endnote using xmlparser setup
DinjerChang May 13, 2023
18ee167
All tags finished except URLs
DinjerChang May 13, 2023
44c52d1
fix url
chiao26168 May 13, 2023
e2de5d0
Merge remote-tracking branch 'origin/fix-for-issue-9538' into chiao-dev
chiao26168 May 13, 2023
1e8fa82
All tags pass test case except URLs and keywords )
DinjerChang May 13, 2023
d03d6d3
Merge remote-tracking branch 'origin/fix-for-issue-9538' into chiao-dev
chiao26168 May 13, 2023
d516bc4
fix: add url feature [with bug]
chiao26168 May 13, 2023
b8653a3
test all passed except EmptyKeywordStyle.xml
DinjerChang May 13, 2023
19a1b75
add changelog, delete Enfnote XSD
DinjerChang May 13, 2023
44f3bbc
~EmptyKeywordStyle.bib expected output fixed, using KeywordList class…
DinjerChang May 15, 2023
c0d4c92
remove issue 9538 log in CHANGELOG.md
DinjerChang May 17, 2023
5c45c17
Merge branch 'main' into fix-for-issue-9538
DinjerChang May 18, 2023
72de1f9
run gradlew rewriteRun
DinjerChang May 18, 2023
1d81bea
Merge branch 'fix-for-issue-9538' of https://github.com/DinjerChang/j…
DinjerChang May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
- In case the library contains empty entries, they are not written to disk. [#8645](https://github.com/JabRef/jabref/issues/8645)
- The formatter `remove_unicode_ligatures` is now called `replace_unicode_ligatures`. [#9890](https://github.com/JabRef/jabref/pull/9890)


### Fixed

- We fixed an issue where the browser import would add ' characters before the BibTeX entry on Linux. [#9588](https://github.com/JabRef/jabref/issues/9588)
Expand Down
8 changes: 0 additions & 8 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,6 @@ processResources {

task generateSource(dependsOn: ["generateBstGrammarSource",
"generateSearchGrammarSource",
"generateEndnoteSource",
"generateCitaviSource"]) {
group = 'JabRef'
description 'Generates all necessary (Java) source files.'
Expand Down Expand Up @@ -289,14 +288,7 @@ tasks.register("generateSearchGrammarSource", JavaExec) {
args = ["-o","src-gen/main/java/org/jabref/search" , "-visitor", "-no-listener", "-package", "org.jabref.search", "$projectDir/src/main/antlr4/org/jabref/search/Search.g4"]
}

task generateEndnoteSource(type: XjcTask) {
group = 'JabRef'
description = "Generates java files for the endnote importer."

schemaFile = "src/main/resources/xjc/endnote/endnote.xsd"
outputDirectory = "src-gen/main/java/"
javaPackage = "org.jabref.logic.importer.fileformat.endnote"
}

task generateCitaviSource(type: XjcTask) {
group = 'JabRef'
Expand Down
Loading