Skip to content

Commit

Permalink
Fix default/fixed filter
Browse files Browse the repository at this point in the history
  • Loading branch information
InfiniteStash committed Feb 17, 2024
1 parent c8ef04a commit 4b4848b
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 15 deletions.
5 changes: 5 additions & 0 deletions frontend/src/components/list/EditList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ interface EditsProps {
defaultVoted?: UserVotedFilterEnum;
defaultBot?: "include" | "exclude" | "only";
showVotedFilter?: boolean;
userSubmitted?: boolean;
defaultUserSubmitted?: boolean;
}

Expand All @@ -45,6 +46,8 @@ const EditListComponent: FC<EditsProps> = ({
defaultVoted,
defaultBot,
showVotedFilter,
userSubmitted,
defaultUserSubmitted,
}) => {
const { page, setPage } = usePagination();
const {
Expand All @@ -70,6 +73,8 @@ const EditListComponent: FC<EditsProps> = ({
defaultVoteStatus,
defaultVoted,
defaultBot,
userSubmitted,
defaultUserSubmitted,
});
const { data, loading } = useEdits({
input: {
Expand Down
34 changes: 19 additions & 15 deletions frontend/src/hooks/useEditFilter.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ interface EditFilterProps {
defaultVoteStatus?: VoteStatusEnum | "all";
defaultVoted?: UserVotedFilterEnum;
defaultBot?: "include" | "exclude" | "only";
defaultUserSubmitted?: boolean;
}

const useEditFilter = ({
Expand All @@ -76,6 +77,7 @@ const useEditFilter = ({
defaultVoteStatus = "all",
defaultVoted,
defaultBot = "include",
defaultUserSubmitted = true,
}: EditFilterProps) => {
const [params, setParams] = useQueryParams({
query: { name: "query", type: "string", default: "" },
Expand All @@ -94,7 +96,7 @@ const useEditFilter = ({
user_submitted: {
name: "user_submitted",
type: "string",
default: "true",
default: defaultUserSubmitted.toString(),
},
});

Expand Down Expand Up @@ -242,20 +244,22 @@ const useEditFilter = ({
value={botOptions.find((opt) => opt.value === selectedBot)}
/>
</Form.Group>
<Form.Group
controlId="include_user_submitted"
className="text-center ms-3"
>
<Form.Label>My Edits</Form.Label>
<Form.Check
className="mt-2"
type="switch"
defaultChecked={userSubmitted}
onChange={(e) =>
setParams("user_submitted", e.currentTarget.checked.toString())
}
/>
</Form.Group>
{fixedUserSubmitted === undefined && (
<Form.Group
controlId="include_user_submitted"
className="text-center ms-3"
>
<Form.Label>My Edits</Form.Label>
<Form.Check
className="mt-2"
type="switch"
defaultChecked={userSubmitted}
onChange={(e) =>
setParams("user_submitted", e.currentTarget.checked.toString())
}
/>
</Form.Group>
)}
</Form>
);

Expand Down
1 change: 1 addition & 0 deletions frontend/src/pages/users/UserEdits.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ const UserEditsComponent: FC<Props> = ({ user, isPrivateUser }) => (
userId={user.id}
defaultVoteStatus={VoteStatusEnum.PENDING}
showVotedFilter={!isPrivateUser}
userSubmitted={true}
/>
</>
);
Expand Down

0 comments on commit 4b4848b

Please sign in to comment.