Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bleed to other elements #50

Merged
merged 3 commits into from
Jun 13, 2017
Merged

Fix bleed to other elements #50

merged 3 commits into from
Jun 13, 2017

Conversation

JakeSidSmith
Copy link
Owner

@JakeSidSmith JakeSidSmith commented May 20, 2017

I have published an alpha version 3.0.2-alpha.1 for testing before release.

If you could please try out this alpha version & let me know on this PR if it has fixed your issue (please provide issue number).

Fixes #29
Fixes #33

Possibly fixes #34 ?
Possibly fixes #48 ?

@nealoke
Copy link

nealoke commented Jun 2, 2017

@JakeSidSmith I would like to test this but i'm to noob to figure out how to download this pull request. Is there a possibility to npm install this pull? Sorry for the lack of experience here :/

@JakeSidSmith
Copy link
Owner Author

JakeSidSmith commented Jun 3, 2017

Yup. It's on npm as 3.0.2-alpha.1. Just update the version in your package.json, clear from your node_modules and npm install. :)

@nealoke
Copy link

nealoke commented Jun 3, 2017

Great, I'll test this the either today or tomorrow, thanks!

@nealoke
Copy link

nealoke commented Jun 11, 2017

@JakeSidSmith so sorry for the late follow up.

I tested with the case provided from @gomo and that is definitly resolved. The only thing that is still happening (in my application) is that for whatever reason the click is being blocked but the keyboard still pops up. (I'm not sure that react-fastclick is the cause though.

Thanks and nice work @JakeSidSmith !

@JakeSidSmith
Copy link
Owner Author

@nealoke on mobile (Android or iOS)?
You want to tap an input, but not have the keyboard open?
Have you tried event.preventDefault() in the onClick?
Or in onTouchStart?

@nealoke
Copy link

nealoke commented Jun 12, 2017

@JakeSidSmith I'm not sure what fixed it but I guess it had something to do with my popup styling (weird though). But can't seem to reproduce it anymore. So all good for me 👍 :)

I tested the test case of @gomo on both IOS and Android (via browserstack)

@JakeSidSmith
Copy link
Owner Author

Guess I'll release this and see how it goes then. :)

@JakeSidSmith JakeSidSmith merged commit f4aa11f into master Jun 13, 2017
@JakeSidSmith JakeSidSmith deleted the bleed-to-other-elements branch June 13, 2017 16:28
@zhengzhiqiang
Copy link

zhengzhiqiang commented Jun 21, 2018

problem

@JakeSidSmith When I use version 3.0.1, it will bleed to another element, so I upgrade to 3.0.2, then I find another problem: when I click an input element, the input will blur.

It happens on iphone devices, 6ps happened always.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants