-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bleed to other elements #50
Conversation
@JakeSidSmith I would like to test this but i'm to noob to figure out how to download this pull request. Is there a possibility to |
Yup. It's on npm as |
Great, I'll test this the either today or tomorrow, thanks! |
@JakeSidSmith so sorry for the late follow up. I tested with the case provided from @gomo and that is definitly resolved. The only thing that is still happening (in my application) is that for whatever reason the click is being blocked but the keyboard still pops up. (I'm not sure that Thanks and nice work @JakeSidSmith ! |
@nealoke on mobile (Android or iOS)? |
@JakeSidSmith I'm not sure what fixed it but I guess it had something to do with my popup styling (weird though). But can't seem to reproduce it anymore. So all good for me 👍 :) I tested the test case of @gomo on both IOS and Android (via browserstack) |
Guess I'll release this and see how it goes then. :) |
@JakeSidSmith When I use version 3.0.1, it will bleed to another element, so I upgrade to 3.0.2, then I find another problem: when I click an input element, the input will blur. It happens on iphone devices, 6ps happened always. |
I have published an alpha version
3.0.2-alpha.1
for testing before release.If you could please try out this alpha version & let me know on this PR if it has fixed your issue (please provide issue number).
Fixes #29
Fixes #33
Possibly fixes #34 ?
Possibly fixes #48 ?