-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: javadocs are now consistent with code, issue #4120 is now fixed. #10762
docs: javadocs are now consistent with code, issue #4120 is now fixed. #10762
Conversation
…is now fixed. Signed-off-by: Daniel Salas <[email protected]>
a1f0969
to
421431e
Compare
Signed-off-by: Daniel Salas <[email protected]>
5f0b979
to
048e34b
Compare
Hi @yurem, hope you are doing great! |
@DanielSEncora github blocks merging because commits are not signed - |
Hi @yuriyz , I have been working to create a new branch, basing it off of the janssenproject main. When I checkout to the newly created branch where I intend to do the required changes and apply the signature correctly I instantly get the below: I have tried to troubleshoot it for hours. From trying to restore the file and also trying to force the checkout of the specific file "git checkout --force upstream/main -- docs/assets/agamalab-flow-passwd-edit-cdiUtil-instance.png", but nothing seems to work. It seems like when I fork the current version of the jansen project this instantly happens, and does not let me move forward since I won't be able to push my changes with that in the way... |
@DanielSEncora I'll check on this issue. I just now took a clone of jans repo but I couldn't replicate the issue. Stay tuned for an update. |
Thank you very much for your feedback @yuriyz and @ossdhaval . I was now able to recreate the issue and fix it, this time my new PR has both GPG, and DCO signatures, it is also verified by Github. Let me know if any other changes are needed.:) New PR: #10813 |
Prepare
Description
Target issue
Fixing issue #4120 #4120
closes #4120
Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:
to indicate documentation changes or if the below checklist is not selected.