Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: javadocs are now consistent with code, issue #4120 is now fixed. #10762

Conversation

DanielSEncora
Copy link
Contributor

Prepare


Description

Target issue

Fixing issue #4120 #4120

closes #4120


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • [ x] I confirm that there is no impact on the docs due to the code changes in this PR.

@DanielSEncora DanielSEncora force-pushed the jans-auth-server-docFixBranch branch from a1f0969 to 421431e Compare January 30, 2025 03:20
jans-auth-server/pom.xml Outdated Show resolved Hide resolved
@DanielSEncora DanielSEncora force-pushed the jans-auth-server-docFixBranch branch from 5f0b979 to 048e34b Compare January 30, 2025 17:11
@yuriyz yuriyz enabled auto-merge (squash) January 31, 2025 11:01
@DanielSEncora
Copy link
Contributor Author

Hi @yurem, hope you are doing great!
Would you be able to take a look at my PR?:)

@yuriyz
Copy link
Contributor

yuriyz commented Feb 3, 2025

@DanielSEncora github blocks merging because commits are not signed - Commits must have verified signatures.. Please re-create PR with signed commits.

@DanielSEncora
Copy link
Contributor Author

Hi @yuriyz , I have been working to create a new branch, basing it off of the janssenproject main. When I checkout to the newly created branch where I intend to do the required changes and apply the signature correctly I instantly get the below:
image

I have tried to troubleshoot it for hours. From trying to restore the file and also trying to force the checkout of the specific file "git checkout --force upstream/main -- docs/assets/agamalab-flow-passwd-edit-cdiUtil-instance.png", but nothing seems to work.

It seems like when I fork the current version of the jansen project this instantly happens, and does not let me move forward since I won't be able to push my changes with that in the way...

@ossdhaval
Copy link
Contributor

ossdhaval commented Feb 4, 2025

way

@DanielSEncora I'll check on this issue. I just now took a clone of jans repo but I couldn't replicate the issue. git status reported a clean working tree.

Stay tuned for an update.

@DanielSEncora
Copy link
Contributor Author

DanielSEncora commented Feb 8, 2025

Thank you very much for your feedback @yuriyz and @ossdhaval . I was now able to recreate the issue and fix it, this time my new PR has both GPG, and DCO signatures, it is also verified by Github. Let me know if any other changes are needed.:)

New PR: #10813

auto-merge was automatically disabled February 8, 2025 04:15

Pull request was closed

@DanielSEncora DanielSEncora deleted the jans-auth-server-docFixBranch branch February 11, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(docs): javadoc comments are inconsistent with code
4 participants