Bug fixes

JellyLabScripts · Dec 22, 2023 · d8c5531 · d8c5531
1 parent 9f0c52e
commit d8c5531
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 24 deletions.
diff --git a/gradle.properties b/gradle.properties
@@ -4,5 +4,5 @@ baseGroup=com.jelly.farmhelperv2
 mcVersion=1.8.9
 modid=farmhelperv2
 modName=FarmHelper
-version=2.2.9-pre1
+version=2.2.9-pre2
 shouldRelease=true
diff --git a/src/main/java/com/jelly/farmhelperv2/config/FarmHelperConfig.java b/src/main/java/com/jelly/farmhelperv2/config/FarmHelperConfig.java
@@ -392,9 +392,7 @@ public class FarmHelperConfig extends Config {
             text = "Sell Inventory Now"
     )
     Runnable autoSellFunction = () -> {
-        if (mc.currentScreen != null && mc.thePlayer != null) {
-            PlayerUtils.closeScreen();
-        }
+        PlayerUtils.closeScreen();
         AutoSell.getInstance().enable(true);
     };
 

diff --git a/src/main/java/com/jelly/farmhelperv2/feature/impl/AutoCookie.java b/src/main/java/com/jelly/farmhelperv2/feature/impl/AutoCookie.java
@@ -95,9 +95,7 @@ public void stop() {
         activating = false;
         autoCookieDelay.reset();
         timeoutClock.reset();
-        if (mc.currentScreen != null && mc.thePlayer != null) {
-            PlayerUtils.closeScreen();
-        }
+        PlayerUtils.closeScreen();
         KeyBindUtils.stopMovement();
         if (MacroHandler.getInstance().isMacroToggled())
             MacroHandler.getInstance().resumeMacro();

diff --git a/src/main/java/com/jelly/farmhelperv2/feature/impl/PestsDestroyer.java b/src/main/java/com/jelly/farmhelperv2/feature/impl/PestsDestroyer.java
@@ -117,11 +117,6 @@ public boolean shouldStartAtMacroStart() {
     @Override
     public void start() {
         if (enabled) return;
-        if (!mc.thePlayer.capabilities.allowFlying) {
-            LogUtils.sendError("[Pests Destroyer] You need to be able to fly!");
-            FarmHelperConfig.enablePestsDestroyer = false;
-            return;
-        }
         lastKilledEntity = null;
         preparing = true;
         if (MacroHandler.getInstance().isMacroToggled()) {
@@ -152,9 +147,7 @@ public void stop() {
             }
         }
         lastKilledEntity = null;
-        if (mc.currentScreen != null && mc.thePlayer != null) {
-            PlayerUtils.closeScreen();
-        }
+        PlayerUtils.closeScreen();
         resetStatesAfterMacroDisabled();
         KeyBindUtils.stopMovement();
     }
@@ -204,16 +197,17 @@ public boolean canEnableMacro(boolean manually) {
             LogUtils.sendError("[Pests Destroyer] You need higher tier (at least second) of Vacuum to use Pests Destroyer!");
             return false;
         }
-
+        if (!mc.thePlayer.capabilities.allowFlying) {
+            LogUtils.sendError("[Pests Destroyer] You need to be able to fly!");
+            return false;
+        }
         if (manually) {
             return true;
         }
-
         if (!PlayerUtils.isStandingOnSpawnPoint() && !PlayerUtils.isStandingOnRewarpLocation()) {
             LogUtils.sendError("[Pests Destroyer] You need to be standing on spawn point or rewarp point to use Pests Destroyer!");
             return false;
         }
-
         return true;
     }
 

diff --git a/src/main/java/com/jelly/farmhelperv2/feature/impl/VisitorsMacro.java b/src/main/java/com/jelly/farmhelperv2/feature/impl/VisitorsMacro.java
@@ -168,9 +168,7 @@ public void stop() {
         manuallyStarted = false;
         LogUtils.sendDebug("[Visitors Macro] Macro stopped");
         rotation.reset();
-        if (mc.currentScreen != null && mc.thePlayer != null) {
-            PlayerUtils.closeScreen();
-        }
+        PlayerUtils.closeScreen();
         KeyBindUtils.stopMovement();
         BaritoneAPI.getProvider().getPrimaryBaritone().getPathingBehavior().cancelEverything();
     }
@@ -1411,9 +1409,7 @@ public void onReceiveChat(ClientChatReceivedEvent event) {
         }
         if (buyState == BuyState.CLICK_CROP || buyState == BuyState.OPEN_BZ) {
             if (msg.startsWith("You need the Cookie Buff")) {
-                if (mc.currentScreen != null && mc.thePlayer != null) {
-                    PlayerUtils.closeScreen();
-                }
+                PlayerUtils.closeScreen();
                 LogUtils.sendDebug("[Visitors Macro] Cookie buff is needed. Skipping...");
                 setBuyState(BuyState.NONE);
                 setVisitorsState(VisitorsState.NONE);