Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add running instruction. #131

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add running instruction. #131

wants to merge 2 commits into from

Conversation

yfaway
Copy link

@yfaway yfaway commented Dec 24, 2022

No description provided.

Copy link

@vincele vincele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I just did the same (for a sonoff ZBDongle 3.0 Plus) today and it worked flawlessly

@JelmerT
Copy link
Owner

JelmerT commented Mar 14, 2024

@yfaway thanks for your PR!

This change overlaps a little with the "usage" section. Would you mind combining both sections and replacing the usage section? Feel free to rename to "how to use" or "using the script" or similar.

@JelmerT
Copy link
Owner

JelmerT commented Mar 14, 2024

note that this scripts isnt just used for the sonoff dongle of course, so you can add that one as an "example"

@JelmerT
Copy link
Owner

JelmerT commented Sep 20, 2024

@yfaway do you want to make these updates?

@yfaway
Copy link
Author

yfaway commented Oct 21, 2024

@yfaway do you want to make these updates?

Sorry I had been quite busy with life. I've made a tiny change. Please could you review. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants