Skip to content

Commit

Permalink
fix openbikesensor#369 remove condition delayMs
Browse files Browse the repository at this point in the history
As I can see delayMs is the delay between the handling of the first byte
of a GPS-Message block and the last Byte of the UbxNavTime Msg.

We have configured the GPS to get a block each second. (Sol, Pollsh,
Dop, Velned and TimeGps)

I don't think the order of the single messages is specified and may
differ.

This delay is no indicator of the quality of the GPS measurement but the
performance of the OBS firmware.
  • Loading branch information
Jens Kassel authored and Jens Kassel committed Nov 27, 2024
1 parent eb5f0b7 commit 5548401
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/gps.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1288,7 +1288,6 @@ void Gps::handleUbxNavTimeGps(const GpsBuffer::UbxNavTimeGps &message, const uin
mIncomingGpsRecord.setWeek(mLastGpsWeek);
}
if ((message.valid & 0x03) == 0x03 // WEEK && TOW
&& delayMs < 20
&& message.tAcc < (20 * 1000 * 1000 /* 20ms */)
&& (mLastTimeTimeSet == 0
|| (mLastTimeTimeSet + (2 * 60 * 1000 /* 2 minutes */)) < receivedMs)) {
Expand Down

0 comments on commit 5548401

Please sign in to comment.