Use gulp from npm repository to make it work without git dependency #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on Windows machines without a git install.
|
Thanks @mziab glad to hear NPM has caught up with its Gulp version. For reference, the source was changed to github due to 4.0 not having been available in NPM at the time. This looks good to me but will leave the merge to @JeremyEnglert so he can do some additional testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm install didn't work out-of-the-box, notably on Windows machines with no git installed. Changing the gulp dependency from github in package.json to a regular one fixes the issue.
And while git should be present in every developer's toolbox, there isn't much of a reason to fetch gulp from github rather than the npm repository. Plus, setting up git on Windows is a bit more of a hassle on Windows machines. Hence, I'm making this PR. Hopefully this saves someone some time.