Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove access calls from trace (for function accesses only). #538

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove access calls from trace (for function accesses only). #538

wants to merge 1 commit into from

Conversation

bbrockbernd
Copy link
Collaborator

Closes #537 And was mentioned here: #534 (comment)

Simplifies:

AccessFunctionRepresentationTest.access$inc(AccessFunctionRepresentationTest#1) at AccessFunctionRepresentationTest$block$1.invoke(AccessFunctionRepresentationTest.kt:19)
    AccessFunctionRepresentationTest#1.inc() at AccessFunctionRepresentationTest.access$inc(AccessFunctionRepresentationTest.kt:13)

Example before:

Detailed trace:
| ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
|                                                                                             Thread 1                                                                                             |
| ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
| AccessFunctionRepresentationTest#1.block(): threw IllegalStateException at BaseRunConcurrentRepresentationTest$testRunWithModelChecker$result$1$1.invoke(RunConcurrentRepresentationTests.kt:40) |
|   block(): threw IllegalStateException at AccessFunctionRepresentationTest.block(AccessFunctionRepresentationTest.kt:13)                                                                         |
|     AccessFunctionRepresentationTestKt.runn(block$1) at AccessFunctionRepresentationTest.block(AccessFunctionRepresentationTest.kt:19)                                                           |
|       block$1.invoke() at AccessFunctionRepresentationTestKt.runn(AccessFunctionRepresentationTest.kt:39)                                                                                        |
|         invoke() at AccessFunctionRepresentationTest$block$1.invoke(AccessFunctionRepresentationTest.kt:19)                                                                                      |
|           AccessFunctionRepresentationTest.access$inc(AccessFunctionRepresentationTest#1) at AccessFunctionRepresentationTest$block$1.invoke(AccessFunctionRepresentationTest.kt:19)             |
|             AccessFunctionRepresentationTest#1.inc() at AccessFunctionRepresentationTest.access$inc(AccessFunctionRepresentationTest.kt:13)                                                      |
|               a ➜ 1 at AccessFunctionRepresentationTest.inc(AccessFunctionRepresentationTest.kt:24)                                                                                              |
|               Nested#1.inc2() at AccessFunctionRepresentationTest.inc(AccessFunctionRepresentationTest.kt:24)                                                                                    |
|                 AccessFunctionRepresentationTest.access$inc3(AccessFunctionRepresentationTest#1) at AccessFunctionRepresentationTest$Nested.inc2(AccessFunctionRepresentationTest.kt:32)         |
|                   AccessFunctionRepresentationTest#1.inc3() at AccessFunctionRepresentationTest.access$inc3(AccessFunctionRepresentationTest.kt:13)                                              |
|                     a ➜ 1 at AccessFunctionRepresentationTest.inc3(AccessFunctionRepresentationTest.kt:28)                                                                                       |
|                     a = 2 at AccessFunctionRepresentationTest.inc3(AccessFunctionRepresentationTest.kt:28)                                                                                       |
|   result: IllegalStateException #1                                                                                                                                                               |
| ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |

after:

Detailed trace:
| ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
|                                                                                             Thread 1                                                                                             |
| ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
| AccessFunctionRepresentationTest#1.block(): threw IllegalStateException at BaseRunConcurrentRepresentationTest$testRunWithModelChecker$result$1$1.invoke(RunConcurrentRepresentationTests.kt:40) |
|   block(): threw IllegalStateException at AccessFunctionRepresentationTest.block(AccessFunctionRepresentationTest.kt:13)                                                                         |
|     AccessFunctionRepresentationTestKt.runn(block$1) at AccessFunctionRepresentationTest.block(AccessFunctionRepresentationTest.kt:19)                                                           |
|       block$1.invoke() at AccessFunctionRepresentationTestKt.runn(AccessFunctionRepresentationTest.kt:39)                                                                                        |
|         invoke() at AccessFunctionRepresentationTest$block$1.invoke(AccessFunctionRepresentationTest.kt:19)                                                                                      |
|           AccessFunctionRepresentationTest.inc() at AccessFunctionRepresentationTest$block$1.invoke(AccessFunctionRepresentationTest.kt:19)                                                      |
|             a ➜ 1 at AccessFunctionRepresentationTest.inc(AccessFunctionRepresentationTest.kt:24)                                                                                                |
|             Nested#1.inc2() at AccessFunctionRepresentationTest.inc(AccessFunctionRepresentationTest.kt:24)                                                                                      |
|               AccessFunctionRepresentationTest.inc3() at AccessFunctionRepresentationTest$Nested.inc2(AccessFunctionRepresentationTest.kt:32)                                                    |
|                 a ➜ 1 at AccessFunctionRepresentationTest.inc3(AccessFunctionRepresentationTest.kt:28)                                                                                           |
|                 a = 2 at AccessFunctionRepresentationTest.inc3(AccessFunctionRepresentationTest.kt:28)                                                                                           |
|   result: IllegalStateException #1                                                                                                                                                               |
| ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |

@bbrockbernd bbrockbernd requested review from eupp and ndkoval February 20, 2025 15:03
@bbrockbernd bbrockbernd linked an issue Feb 20, 2025 that may be closed by this pull request
Remove .access$ calls #537
Open
@bbrockbernd bbrockbernd self-assigned this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eupp eupp Awaiting requested review from eupp

@ndkoval ndkoval Awaiting requested review from ndkoval

At least 1 approving review is required to merge this pull request.

Assignees

@bbrockbernd bbrockbernd

Labels
general-purpose mc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove .access$ calls
1 participant
@bbrockbernd