Support time and random native calls in trace debugger #541
+1,105
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhelenskiy
force-pushed
the
native-calls-attempt2
branch
from
93fb82c to
5f3b23e
Compare
…ts for deterministic randomness and fix found bugs
zhelenskiy
force-pushed
the
native-calls-attempt2
branch
from
5f3b23e to
f9ed737
Compare
eupp
requested changes
Feb 21, 2025
| @@ -83,7 +81,18 @@ abstract class ManagedStrategy( | |||
| // Tracker of objects' allocations and object graph topology. | |||
| protected abstract val objectTracker: ObjectTracker? | |||
| // Tracker of objects' identity hash codes. | |||
| internal abstract val identityHashCodeTracker: ObjectIdentityHashCodeTracker | |||
| private val identityHashCodeTracker = ObjectIdentityHashCodeTracker() | |||
| private val nativeMethodCallStatesTracker = NativeMethodCallStatesTracker() | |||
There was a problem hiding this comment.
Please add comment similar to other trackers.
| internal abstract val identityHashCodeTracker: ObjectIdentityHashCodeTracker | ||
| private val identityHashCodeTracker = ObjectIdentityHashCodeTracker() | ||
| private val nativeMethodCallStatesTracker = NativeMethodCallStatesTracker() | ||
| internal val traceDebuggerEventTrackers: Map<TraceDebuggerTracker, AbstractTraceDebuggerEventTracker> = mapOf( |
There was a problem hiding this comment.
Add an empty line before this tracker.
| } | ||
| internal fun closeTraceDebuggerTrackers() { | ||
| traceDebuggerEventTrackers.values.forEach { it.close() } | ||
| } |
| @@ -1153,6 +1164,12 @@ abstract class ManagedStrategy( | |||
| objectTracker?.registerNewObject(obj) | |||
| } | |||
| } | |||
|
|
|||
| override fun getNativeCallStateOrNull(id: Id): Any? = nativeMethodCallStatesTracker.getStateOrNull(id) | |||
There was a problem hiding this comment.
Empty line + wrap method body in {} or put on next line.
| * with this file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
| */ | ||
|
|
||
| package org.jetbrains.kotlinx.lincheck.strategy.managed |
There was a problem hiding this comment.
Anything ASM or bytecode related should be put in transformation subpackage.
| val expectedResult = List(10) { 0 } | ||
| require(randomList == expectedResult) { "Wrong randomizer: $randomList != $expectedResult" } | ||
| } | ||
| } |
There was a problem hiding this comment.
TODO: add representation test for native method call trackers
| void advanceCurrentTraceDebuggerEventTrackerId(TraceDebuggerTracker tracker, long oldId); | ||
|
|
||
| Object getNativeCallStateOrNull(long id); | ||
| void setNativeCallState(long id, Object state); |
There was a problem hiding this comment.
Think about how these methods should interact with beforeMethodCall and other method tracking functions.
| @@ -66,34 +72,94 @@ internal class DeterministicHashCodeTransformer( | |||
| } | |||
|
|
|||
| /** | |||
| * [DeterministicTimeTransformer] tracks invocations of [System.nanoTime] and [System.currentTimeMillis] methods, | |||
| * [FakeDeterministicTimeTransformer] tracks invocations of [System.nanoTime] and [System.currentTimeMillis] methods, | |||
There was a problem hiding this comment.
Let's now split it into DeterministicRandomTransformers.kt and DeterministicTimeTransformers.kt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.