-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse unitest.mock assertions as diffs #256
Open
ikonst
wants to merge
6
commits into
JetBrains:master
Choose a base branch
from
ikonst:fix-mock-assert-diffs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbb41ac
to
414d70a
Compare
ikonst
commented
Sep 10, 2021
74c3704
to
7b34e96
Compare
7b34e96
to
efb4499
Compare
@throwable-one can take a look? |
efb4499
to
4158116
Compare
4158116
to
6fe7d6b
Compare
@mikekidya can review? |
@mikekidya ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
unitest.mock
failed assertions are not recognized as "diffs" in PyCharm. This teaches the plugin to recognize those assertions and emit theEqualsAssertionError
with the actual/expected.Additionally:
pytest-mock (a popular pytest plugin providing the
mocker
fixture) has an improved reporting feature which patchesunittest.mock
and changes the format of the reports.To work well out of the box, we handle both the stock and "patched" outputs.
For example, this test
would result in this output:
![image](https://user-images.githubusercontent.com/1186084/196330645-efeb1cd8-2f6d-4314-9556-23c65475f065.png)
![image](https://user-images.githubusercontent.com/1186084/196330751-3e6f8b96-2377-433c-a7fa-2e64ba7e892a.png)
and diff viewer: