Minor API improvements.

JetBrains · Nov 7, 2023 · b43a847 · b43a847
1 parent 8575801
commit b43a847
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/vectoriadb-bench/src/main/java/jetbrains/vectoriadb/bench/Sift1MBench.java b/vectoriadb-bench/src/main/java/jetbrains/vectoriadb/bench/Sift1MBench.java
@@ -89,7 +89,7 @@ public static void main(String[] args) {
             System.out.printf("%d vectors uploaded in %d ms, building index %n", vectors.length, ts2 - ts1);
 
             ts1 = System.currentTimeMillis();
-            client.buildIndex(indexName);
+            client.triggerIndexBuild(indexName);
 
             var stopPrintStatus = new AtomicBoolean();
 

diff --git a/vectoriadb-interface/src/main/proto/IndexManager.proto b/vectoriadb-interface/src/main/proto/IndexManager.proto
@@ -20,7 +20,7 @@ import "google/protobuf/empty.proto";
 
 service IndexManager {
   rpc CreateIndex(CreateIndexRequest) returns (CreateIndexResponse) {}
-  rpc BuildIndex(IndexNameRequest) returns (google.protobuf.Empty) {}
+  rpc TriggerIndexBuild(IndexNameRequest) returns (google.protobuf.Empty) {}
   rpc DropIndex(IndexNameRequest) returns (google.protobuf.Empty) {}
   rpc ListIndexes(google.protobuf.Empty) returns (IndexListResponse) {}
   rpc RetrieveIndexState(IndexNameRequest) returns (IndexStateResponse) {}

diff --git a/vectoriadb-java-client/src/main/java/jetbrains/vectoriadb/client/VectoriaDBClient.java b/vectoriadb-java-client/src/main/java/jetbrains/vectoriadb/client/VectoriaDBClient.java
@@ -77,13 +77,13 @@ public IndexMetadata createIndex(final String indexName, final Distance distance
                 response.getCompressionRatio(), response.getDistanceMultiplier());
     }
 
-    public void buildIndex(final String indexName) {
+    public void triggerIndexBuild(final String indexName) {
         var builder = IndexManagerOuterClass.IndexNameRequest.newBuilder();
         builder.setIndexName(indexName);
 
         var request = builder.build();
         //noinspection ResultOfMethodCallIgnored
-        indexManagerBlockingStub.buildIndex(request);
+        indexManagerBlockingStub.triggerIndexBuild(request);
     }
 
     public void dropIndex(final String indexName) {

diff --git a/vectoriadb-server/src/main/java/jetbrains/vectoriadb/server/IndexManagerServiceImpl.java b/vectoriadb-server/src/main/java/jetbrains/vectoriadb/server/IndexManagerServiceImpl.java
@@ -359,7 +359,7 @@ public void createIndex(IndexManagerOuterClass.CreateIndexRequest request,
 
 
     @Override
-    public void buildIndex(IndexManagerOuterClass.IndexNameRequest request, StreamObserver<Empty> responseObserver) {
+    public void triggerIndexBuild(IndexManagerOuterClass.IndexNameRequest request, StreamObserver<Empty> responseObserver) {
         operationsSemaphore.acquireUninterruptibly();
         try {
             if (closed) {

diff --git a/vectoriadb-server/src/test/java/jetbrains/vectoriadb/server/IndexManagerTest.java b/vectoriadb-server/src/test/java/jetbrains/vectoriadb/server/IndexManagerTest.java
@@ -133,7 +133,7 @@ public void testBuildNotExistingIndex() throws Exception {
             indexNameRequestBuilder.setIndexName(indexName);
 
             var buildIndexRecorder = StreamRecorder.<Empty>create();
-            indexManagerService.buildIndex(indexNameRequestBuilder.build(), buildIndexRecorder);
+            indexManagerService.triggerIndexBuild(indexNameRequestBuilder.build(), buildIndexRecorder);
 
             var completed = buildIndexRecorder.awaitCompletion(1, TimeUnit.MICROSECONDS);
             Assert.assertTrue(completed);
@@ -467,7 +467,7 @@ private static void buildIndex(String indexName, IndexManagerServiceImpl indexMa
         indexNameRequestBuilder.setIndexName(indexName);
 
         var buildIndexRecorder = StreamRecorder.<Empty>create();
-        indexManagerService.buildIndex(indexNameRequestBuilder.build(), buildIndexRecorder);
+        indexManagerService.triggerIndexBuild(indexNameRequestBuilder.build(), buildIndexRecorder);
 
         checkCompleteness(buildIndexRecorder);
         while (true) {