Optimization of Long boxing in the PackedLongHashSet #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optimization is based on the boxing elimination, now `PackedLongHashSet.contains` directly uses the performant `getEntry(long)` method thus avoiding the boxing and associated allocations Before: ``` Benchmark Mode Cnt Score Error Units dataStructures.JMHPackedLongHashSetBenchmark.tryContains thrpt 30 14,195 ± 1,574 ops/ms ``` After: ``` Benchmark Mode Cnt Score Error Units dataStructures.JMHPackedLongHashSetBenchmark.tryContains thrpt 30 46,406 ± 1,430 ops/ms ```
andrii0lomakin
approved these changes
Apr 19, 2024
jk1
pushed a commit
that referenced
this pull request
Apr 26, 2024
The optimization is based on the boxing elimination, now `PackedLongHashSet.contains` directly uses the performant `getEntry(long)` method thus avoiding the boxing and associated allocations Before: ``` Benchmark Mode Cnt Score Error Units dataStructures.JMHPackedLongHashSetBenchmark.tryContains thrpt 30 14,195 ± 1,574 ops/ms ``` After: ``` Benchmark Mode Cnt Score Error Units dataStructures.JMHPackedLongHashSetBenchmark.tryContains thrpt 30 46,406 ± 1,430 ops/ms ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Optimization of Long boxing in the PackedLongHashSet
The optimization is based on the boxing elimination, now
PackedLongHashSet.containsdirectly uses the performantgetEntry(long)method thus avoiding the boxing and associated allocationsBefore:
After:
Checklist
[x] I have added unit tests to the code I am submitting
[x] My unit tests cover both failure and success scenarios
[x] If applicable, I have discussed my architecture