#XD-957 fixed #140
Merged
#XD-957 fixed #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrii0lomakin
requested changes
Apr 23, 2024
There was a problem hiding this comment.
Hi @leostryuk .
Please also add test that include case when part of issues will be out of the range of the expected result.
|
But it's there. only issue2 and issue3 are in response.
…On Tue, Apr 23, 2024 at 2:43 PM Andrii Lomakin ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hi @leostryuk <https://github.com/leostryuk> .
Please also add test that include case when part of issues will be out of
the range of the expected result.
—
Reply to this email directly, view it on GitHub
<#140 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANIB6LSTK22LCWYIZ36M7DY6ZJQFAVCNFSM6AAAAABGUN5AU2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMJXGE2DCNJTGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
andrii0lomakin
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Related issues
A list of issues either fixed, containing architectural discussions, otherwise relevant
for this Pull Request.
Additional Notes
Anything else we should know when reviewing?
Checklist
[] I have added unit tests to the code I am submitting
[] My unit tests cover both failure and success scenarios
[] If applicable, I have discussed my architecture