Skip to content

Commit

Permalink
fix(client): app crash on add access key edit (#2340)
Browse files Browse the repository at this point in the history
* fix(client): infinite render on key edit

* no need for nullable

* use input
  • Loading branch information
daniellacosse authored Jan 22, 2025
1 parent a368f72 commit a8d9f8f
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions client/src/www/views/root_view/add_access_key_dialog/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,6 @@ export class AddAccessKeyDialog extends LitElement {
<section>
<md-filled-text-field
.error=${this.accessKey && !this.isValidAccessKey}
@change=${this.updateIsValidAccessKey(
this.accessKey,
this.validateAccessKey
)}
@input=${this.handleEdit}
error-text="${this.localize('add-access-key-dialog-error-text')}"
label="${this.localize('add-access-key-dialog-label')}"
Expand Down Expand Up @@ -131,6 +127,8 @@ export class AddAccessKeyDialog extends LitElement {

private handleEdit(event: InputEvent) {
this.accessKey = (event.target as HTMLInputElement).value;

this.updateIsValidAccessKey(this.accessKey, this.validateAccessKey);
}

private handleConfirm() {
Expand Down

0 comments on commit a8d9f8f

Please sign in to comment.