Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(client): make parsing async and config an opaque string #2324

Merged
merged 9 commits into from
Jan 15, 2025
Merged

refactor(client): make parsing async and config an opaque string #2324

merged 9 commits into from
Jan 15, 2025

Conversation

fortuna
Copy link
Collaborator

@fortuna fortuna commented Jan 13, 2025 •
edited
Loading

This PR turns config parsing async, in preparation for parsing in the Go code. It had ripple effect all over the Typescript code.

This also changes the parsing API to output firstHop + transport, with transport being an opaque string as opposed to an object.

@fortuna fortuna requested review from sbruens and jyyi1 January 13, 2025 17:26
@fortuna fortuna requested review from a team as code owners January 13, 2025 17:26
This was referenced Jan 13, 2025
Draft
Open
@fortuna fortuna requested a review from sbruens January 13, 2025 20:03
sbruens
sbruens approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@sbruens sbruens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting this out from the other PR. It will make it easier to digest and review the config change.

jyyi1
jyyi1 reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@jyyi1 jyyi1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting the PR! This is a lot clearer and easier to review! The logic looks good, with some small comments.

client/src/cordova/plugin/apple/src/OutlinePlugin.swift Outdated Show resolved Hide resolved
client/src/cordova/plugin/apple/src/OutlinePlugin.swift Outdated Show resolved Hide resolved
client/src/www/app/main.cordova.ts Show resolved Hide resolved
client/src/www/app/outline_server_repository/vpn.fake.ts Outdated Show resolved Hide resolved
client/src/www/app/outline_server_repository/vpn.fake.ts Outdated Show resolved Hide resolved
client/src/www/app/outline_server_repository/server.ts Outdated Show resolved Hide resolved
client/src/www/app/app.ts Show resolved Hide resolved
client/src/www/app/outline_server_repository/index.ts Outdated Show resolved Hide resolved
client/src/www/app/outline_server_repository/index.ts Outdated Show resolved Hide resolved
client/src/www/views/root_view/add_access_key_dialog/index.ts Show resolved Hide resolved
@fortuna fortuna requested a review from jyyi1 January 13, 2025 23:23
jyyi1
jyyi1 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks for the update.

@fortuna fortuna changed the title refactor(client): make parsing async refactor(client): make parsing async and config an opaque string Jan 14, 2025
@fortuna fortuna enabled auto-merge (squash) January 14, 2025 23:45
@fortuna fortuna merged commit eca8e40 into master Jan 15, 2025
20 checks passed
@fortuna fortuna deleted the fortuna-async branch January 15, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyyi1 jyyi1 jyyi1 approved these changes

@sbruens sbruens sbruens approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fortuna @sbruens @jyyi1