feat(client): introduce extensible YAML config #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortuna
force-pushed
the
fortuna-go-config
branch
from
2de4bea to
1093e52
Compare
sbruens
approved these changes
Jan 16, 2025
|
@sbruens @jyyi1 here is an attempt to document the config format. Please let me know how I can improve it: https://github.com/Jigsaw-Code/outline-apps/blob/fortuna-go-config/client/config.md |
jyyi1
approved these changes
Jan 17, 2025
client/go/outline/method_channel.go
Outdated
| firstHop = streamFirstHop | ||
| } | ||
| return &InvokeMethodResult{ | ||
| Value: firstHop, |
There was a problem hiding this comment.
Shall we return an error here or just the empty result?
There was a problem hiding this comment.
Not having a shared first hop is not really an error. We just won't have something to show. Perhaps firsthHop should be a struct instead, and we could show both.
Without the struct, people won't be able to use separate endpoints for tcp and udp on Windows, even if they are on the same IP, because we don't have the IP returned
| provider := newTestProvider() | ||
|
|
||
| node, err := ParseConfigYAML(` | ||
| $type: ss |
client/go/outline/config/parse.go
Outdated
| ) | ||
|
|
||
| // ConfigParserKey is the config key used to specify the parser to use to parse an object. | ||
| const ConfigParserKey = "$parser" |
There was a problem hiding this comment.
Should this be $parser or $type? The document says $type.
fortuna
commented
Jan 17, 2025
fortuna
force-pushed
the
fortuna-go-config
branch
from
80d1206 to
e60341a
Compare
fortuna
commented
Jan 27, 2025
client/go/outline/config/parse.go
Outdated
| ) | ||
|
|
||
| // ConfigParserKey is the config key used to specify the parser to use to parse an object. | ||
| const ConfigParserKey = "$parser" |
| provider := newTestProvider() | ||
|
|
||
| node, err := ParseConfigYAML(` | ||
| $type: ss |
sbruens
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 2 of #2306.
TODO:
$parserand$type