fix: introduce first-supported Endpoint #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyyi1
reviewed
Jan 31, 2025
| tcp: | ||
| $type: shadowsocks | ||
| endpoint: | ||
| $type: first-supported |
There was a problem hiding this comment.
How about first-success, so it can try multiple domains?
There was a problem hiding this comment.
It's a bit tricky. It requires testing each of them. Then we may need to update the list too. We can add that later, since it's a can of worms.
jyyi1
reviewed
Jan 31, 2025
jyyi1
approved these changes
Jan 31, 2025
client/config.md
Outdated
| @@ -115,6 +117,34 @@ transport: | |||
| secret: SS_SECRET | |||
| ``` | |||
|
|
|||
| Note that Websockets is not yet supported on Windows. In order to have a single config for all platforms, use a first-supported endpoint: | |||
There was a problem hiding this comment.
Suggested change
| Note that Websockets is not yet supported on Windows. In order to have a single config for all platforms, use a first-supported endpoint: | |
| Note that Websockets is not yet supported on Windows. In order to have a single config for all platforms, use a `first-supported` endpoint: |
sbruens
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.