feat(server): allow running Outline on a server with another Watchtower #1255
Conversation
AlekSi
force-pushed
the
watchtower-scope
branch
from
57130f7 to
b0e7303
Compare
| @@ -304,6 +304,7 @@ function start_shadowbox() { | |||
| local -ar docker_shadowbox_flags=( | |||
| --name "${CONTAINER_NAME}" --restart always --net host | |||
| --label 'com.centurylinklabs.watchtower.enable=true' | |||
| --label 'com.centurylinklabs.watchtower.scope=shadowbox' | |||
There was a problem hiding this comment.
Will this prevent watchtower itself from being updated?
There was a problem hiding this comment.
No, the label and the flag will be applied simultaneously. So old version without the label and the flag will update itself to a new version with the label and the flag.
There was a problem hiding this comment.
Changed scope name to make it a bit more explicit. PTAL
See https://containrrr.dev/watchtower/running-multiple-instances/ `com.centurylinklabs.watchtower.enable` and `--label-enable` are kept for backward compatibility. Closes Jigsaw-Code#48.
AlekSi
force-pushed
the
watchtower-scope
branch
from
b0e7303 to
7720e77
Compare
| @@ -333,10 +334,12 @@ function start_watchtower() { | |||
| # testing). Otherwise refresh every hour. | |||
| local -ir WATCHTOWER_REFRESH_SECONDS="${WATCHTOWER_REFRESH_SECONDS:-3600}" | |||
| local -ar docker_watchtower_flags=(--name watchtower --restart always \ | |||
| --label 'com.centurylinklabs.watchtower.enable=true' \ | |||
There was a problem hiding this comment.
furthermore, this change now allows watchtower to update itself
right now every instance of outline-server has its watchtower image stuck on the installation version due to the presence of --label-enable
|
Ping |
|
@fortuna poke |
|
I'm sorry, this felt through the cracks. I believe it's a good change. Though it seems it has some conflicts with the existing code now that need to be fixed. |
# Conflicts: # src/server_manager/install_scripts/install_server.sh
|
@fortuna PTAL |
sbruens
changed the title
See https://containrrr.dev/watchtower/running-multiple-instances/
com.centurylinklabs.watchtower.enableand--label-enableare kept for backward compatibility.Closes #48.