Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sentry_webhook): use Node.js 18 runtime version #1456

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Nov 27, 2023

Node.js 12 will be deprecated on Jan 30, 2024. This changes the runtime to Node.js 18, which is listed as the recommended version at https://cloud.google.com/functions/docs/concepts/nodejs-runtime.

@sbruens sbruens requested a review from a team as a code owner November 27, 2023 16:32
Copy link
Contributor

@daniellacosse daniellacosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

ideally this version is pulled in from the package.json or the .nvmrc, but this is good!

@sbruens sbruens merged commit 4c14a15 into master Nov 27, 2023
13 checks passed
@sbruens sbruens deleted the sbruens/nodejs branch November 27, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants