Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager/electron): replace turned down OmahaProxy with ChromiumDash #1462

Merged
merged 5 commits into from
Dec 11, 2023
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -24,8 +24,7 @@
"typescript": "^4"
},
"engines": {
"node": "^18.16.0",
"npm": "^9.5.1"
"node": "18.x.x"
},
"scripts": {
"action": "bash ./scripts/run_action.sh",
10 changes: 5 additions & 5 deletions src/server_manager/electron_and_karma_chromium.spec.ts
Original file line number Diff line number Diff line change
@@ -22,16 +22,16 @@ import {config} from './package.json';

describe('Karma', () => {
it('uses the correct Chromium version', async (done) => {
// Omaha Proxy is a service maintained by the Chrome team which serves metadata about current
// and legacy Chrome versions.
const electronChromiumVersionInfo = <{chromium_base_position?: string}>(
const electronChromiumVersionInfo = <{chromium_main_branch_position?: string}>(
await (
await fetch(
`http://omahaproxy.appspot.com/deps.json?version=${electronToChromium(electronVersion)}`
`https://chromiumdash.appspot.com/fetch_version?version=${electronToChromium(
electronVersion
)}`
)
).json()
);
const electronChromeRevision = electronChromiumVersionInfo.chromium_base_position;
const electronChromeRevision = electronChromiumVersionInfo.chromium_main_branch_position;
expect(electronChromeRevision).toEqual(config.PUPPETEER_CHROMIUM_REVISION);
done();
});
Loading