Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile against Paper #282

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Compile against Paper #282

wants to merge 14 commits into from

Conversation

Jikoo
Copy link
Owner

@Jikoo Jikoo commented Jan 24, 2025 •
edited
Loading

  • Compile against Paper directly
  • Convert to Gradle
  • Build all distributables as part of standard build process

TODO:

  • Compile resource pack
  • Compile addon
  • Update/remove scripts
  • Clean up compiler warnings where possible
  • Compile Spigot module against Spigot
    • May want to write a precompiled script plugin to download and install if necessary rather than rely on external scripts/setup
    • Address SpecialSource not being able to rename fields with reflection
    • Address PlayerManager diff (spawnIn and inventory open calling)

Closes #279

Jikoo added 14 commits January 24, 2025 16:36
@Jikoo
Compile against Paper with Gradle
390b48f
@Jikoo
Re-add automatic version info
165e64f 
Gradle appears to struggle with replacement strings containing periods using this technique, and the other struggles with fetching project information.
@Jikoo
Cleaner assembly order
3d38a25
@Jikoo
Build resource pack
abf19d6
@Jikoo
Build working branch
f122d5d
@Jikoo
Fix action name
1b92302
@Jikoo
Mark scripts executable
538dae8
@Jikoo
Resolve capabilities
f09bd82 
Unsure why this is a problem on GitHub Actions, runs fine locally. Maybe a cache issue. I love Gradle.
@Jikoo
Copy shaded plugin
e639ec9
@Jikoo
Build addons
5776d5d 
Well, addon, but hey, we'll get to that, probably.
@Jikoo
Remove disabled rewrite warning
608fb36
@Jikoo
Drop unnecessary scripts
ffdd3d2 
GitHub has an auto-generated changelog (that I like less because it only supports PRs rather than commits, but oh well)
All assets are now in ./dist/ already, no need to rebuild rpack
No more Maven, so scripts would need a complete overhaul anyway, unsure how I will be approaching that.
@Jikoo
Drop redundant variable
52dd44c 
This should (theoretically) be fine - it was originally used to double newlines because Actions was not able to handle expanding a multi-line string into YAML. This now results in CF changelogs being extra spaced out. Sometimes when I go to upload additional files I actually paste in the body myself (gasp) to fix the appearance.
@Jikoo
Clean up some warnings
a1133c5 
Probably will need to install Spigot dependency directly for Spigot module, which is unfortunate, but it is what it is. Definitely need a Spigot-specific version of PlayerManager.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compile specific modules for Paper
1 participant
@Jikoo