cleanup cw_decred and make decred addresses selectable #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah it works! I guess what I did was wrong was not assigning the I don't like how this doesn't update the selected address currently if it is used. |
JoeGruffins
reviewed
Jan 24, 2025
|
|
||
| String currentAddr = ''; |
There was a problem hiding this comment.
What if we left this variable and then in performBackgroundTasks We check for a new address, and if it's different than what we had saved here, we update the selectedAddr and this one? That way we can keep the default new.
JoeGruffins
reviewed
Jan 24, 2025
itswisdomagain
force-pushed
the
joe_updateaddresses
branch
from
ef34956 to
d2e79a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.