Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing on minimum-required and latest Python version only #1585

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

roshii
Copy link
Contributor

@roshii roshii commented Oct 28, 2023

Taking the same approach as bitcoind version testing, setting only minimum required and latest Python version in CI. Testing so many versions does not bring much added value IMHO.

@roshii roshii changed the title Testing on minimum required and latest Python version only Testing on minimum-required and latest Python version only Oct 28, 2023
@kristapsk
Copy link
Member

Likely makes sense.

@roshii I merged #1583, could you rebase against master?

@roshii roshii force-pushed the ci-min-max-python-only branch from 6ea72c3 to 15cdadb Compare October 29, 2023 06:10
@roshii
Copy link
Contributor Author

roshii commented Oct 29, 2023

Rebased

@roshii
Copy link
Contributor Author

roshii commented Oct 29, 2023

Python 3.12 compatibility likely require further (upstream) patches. I also had issues while testing locally but suspected local configuration error since I could not reproduce... Too much optimism on this one 😄

I shall adjust this PR to 3.11 max and create new PR to set joinmarket compatibility to >=3.7,<3.12.

@roshii roshii force-pushed the ci-min-max-python-only branch from 15cdadb to 4f4945e Compare October 29, 2023 09:06
@kristapsk
Copy link
Member

I will merge this. It will speed up CI and it's trivial to revert if we change our minds.

Copy link
Member

@kristapsk kristapsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4f4945e

@kristapsk kristapsk merged commit 2e0b3a4 into JoinMarket-Org:master Nov 2, 2023
8 checks passed
@roshii roshii deleted the ci-min-max-python-only branch November 3, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants