Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ShellCheck warnings and add ShellCheck to CI #1591

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Fix ShellCheck warnings and add ShellCheck to CI #1591

merged 2 commits into from
Oct 31, 2023

Conversation

kristapsk
Copy link
Member

Could use ./test/lint/lint-shell.sh instead, but this way was simpler.

https://github.com/marketplace/actions/shellcheck

@kristapsk kristapsk changed the title Fix ShellCheck warnings and ShellCheck to CI Fix ShellCheck warnings and add ShellCheck to CI Oct 30, 2023
roshii
roshii approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@roshii roshii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3e71df5

@kristapsk kristapsk merged commit 911b156 into JoinMarket-Org:master Oct 31, 2023
20 checks passed
@kristapsk kristapsk deleted the ci-shellcheck branch October 31, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roshii roshii roshii approved these changes

Assignees
No one assigned
Labels
Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristapsk @roshii