-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum required Bitcoin Core version from 0.18 to 22.0 #1719
Bump minimum required Bitcoin Core version from 0.18 to 22.0 #1719
Conversation
For reviewers - please check that I haven't missed any mentions of older Bitcoin Core versions somewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cACK
here is a mention too
Work in your `jmvenv` virtual environment as for all Joinmarket work. Make sure to have [bitcoind](https://bitcoin.org/en/full-node) 0.18 or newer installed. Also need miniircd installed to the root (i.e. in your `joinmarket-clientserver` directory): |
why v20 and not 21? |
Ohh, right! Looked at https://bitcoincore.org recent posts, but they announced so many at the same time as separate posts that to see v20, one must open https://bitcoincore.org/en/blog/ with more history. |
81607a6
to
c51db62
Compare
Updated from v20 to v21. |
c51db62
to
902289c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 902289c
new ones got disclosed, for <v22. and iirc the next one will be disclosed in september and then another later this year. I think bumping the min version still makes sense, just to keep in mind that it will need to be bumped more regularly |
902289c
to
6b46239
Compare
Thanks for notifying, updated to v22. |
There have been multiple vulnerabilities disclosed for older versions, we should not recommend people using them. * Disclosure of memory DoS due to malicious P2P message - https://bitcoincore.org/en/2024/07/03/disclose-inv-buffer-blowup/ * Disclosure of CPU DoS due to malicious P2P message - https://bitcoincore.org/en/2024/07/03/disclose-getdata-cpu/ * Disclosure of crash due to malicious BIP72 URI - https://bitcoincore.org/en/2024/07/03/disclose-bip70-crash/ * Disclosure of netsplit due to malicious P2P messages by first 200 peers - https://bitcoincore.org/en/2024/07/03/disclose-timestamp-overflow/ * Disclosure of CPU/memory DoS due to many malicious peers - https://bitcoincore.org/en/2024/07/03/disclose-unbounded-banlist/ * Disclosure of censoring unconfirmed transactions to a specific victim - https://bitcoincore.org/en/2024/07/03/disclose_already_asked_for/ * Security advisories for bugs fixed as of Bitcoin Core v22.0 - bitcoin-core/bitcoincore.org#1049
6b46239
to
ee4a3fa
Compare
This had been open for long enough time, there were no objections, merging. |
…24.0.1 b456968 Bump minimum required Bitcoin Core version from 22.0 to 24.0.1 (Kristaps Kaupe) Pull request description: Security vulnerability has been disclosed for versions older than 24.0.1, which are also currently EOL. https://bitcoincore.org/en/2024/09/18/disclose-headers-oom/ Similar to #1719. Top commit has no ACKs. Tree-SHA512: a922aaece30abb116f3155c68484b6bca2a8593d3f462b711cfbd1b03781606eee1e6f348d9e2d35a67b65121a6faaba617d9b6f58502d705c81c43ea145ea31
There have been multiple vulnerabilities disclosed for older versions, we should not recommend people using them.