Allow customizing some of the server options #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiennou
force-pushed
the
feature/custom-server-options
branch
3 times, most recently
from
07627be to
769be9f
Compare
Jomik
reviewed
Dec 14, 2023
config.yml
Outdated
| @@ -1,6 +1,15 @@ | |||
| mods: | |||
| - screepsmod-auth | |||
| - screepsmod-admin-utils | |||
Jomik
requested changes
Dec 14, 2023
config.yml
Outdated
Comment on lines
10
to
15
| runner_threads: 4 | ||
| # The number of room processor worker processes to launch. | ||
| # Don't set this option greater than the number of your physical CPU cores. | ||
| processors_cnt: 2 | ||
| # If set, forward console messages to terminal | ||
| log_console: false |
There was a problem hiding this comment.
Since this is a whitelist anyway, it should be following the same naming convention as the rest of the config. So runnerThreads and processorCount.
screeps-start.js
Outdated
|
|
||
| const keys = ['runner_threads', 'processors_cnt', 'log_console']; | ||
| for (const key of keys) { | ||
| if (options[key]) { |
There was a problem hiding this comment.
This line only overrides if the option is truthy. We should just check if it exists.
Suggested change
| if (options[key]) { | |
| if (key in options) { |
There was a problem hiding this comment.
Oh, just realised that this should not be checking options but config.serverConfig :)
This passes in a few whitelisted keys from config.yml to override defaults from the default `.screepsrc` file.
Jomik
force-pushed
the
feature/custom-server-options
branch
from
769be9f to
061a3f9
Compare
Jomik
requested changes
Dec 18, 2023
screeps-start.js
Outdated
|
|
||
| const keys = ['runner_threads', 'processors_cnt', 'log_console']; | ||
| for (const key of keys) { | ||
| if (options[key]) { |
There was a problem hiding this comment.
Oh, just realised that this should not be checking options but config.serverConfig :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes in a few whitelisted keys from config.yml to override defaults from the default
.screepsrcfile.