-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bevy 0.10 support #45
Conversation
37139c6
to
70d03f9
Compare
70d03f9
to
9047184
Compare
Co-authored-by: Hennadii Chernyshchyk <[email protected]>
Co-authored-by: Hennadii Chernyshchyk <[email protected]>
@BrandonDyer64 could you cleanup |
Yeah I'll have a look |
Would you prefer adding an exception to the deny file, or switching xml-rs to another crate, like quick-xml? |
I would add is as exception since it's used by |
Thank you for your work here. I had already started a 0.6 branch (#42), but I suppose if people really want a quick replacement we could make this the 0.6 version and release my update as 0.7. |
@JonahPlusPlus I like the idea of getting something in quick for Bevy 0.10 support, and having another update with all the goodies you've got in store for us at a later date. Many devs, like myself, are eager to start working with the new engine update, and would love to include bevy_atmosphere in their projects as soon as possible. |
Okay, I'll review and merge this, make some minor changes and it should be released later today or tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Just a 1:1 update to Bevy 0.10
All of the examples appear to run normally