Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bevy 0.10 support #45

Merged
merged 4 commits into from
Mar 12, 2023
Merged

Conversation

BrandonDyer64
Copy link
Contributor

Just a 1:1 update to Bevy 0.10

All of the examples appear to run normally

@BrandonDyer64 BrandonDyer64 force-pushed the bevy-v0.10 branch 3 times, most recently from 37139c6 to 70d03f9 Compare March 10, 2023 02:25
examples/splitscreen.rs Outdated Show resolved Hide resolved
src/plugin.rs Outdated Show resolved Hide resolved
BrandonDyer64 and others added 2 commits March 11, 2023 08:52
Co-authored-by: Hennadii Chernyshchyk <[email protected]>
Co-authored-by: Hennadii Chernyshchyk <[email protected]>
@Shatur
Copy link
Collaborator

Shatur commented Mar 11, 2023

@BrandonDyer64 could you cleanup deny.toml? The warnings are outlined in https://github.com/JonahPlusPlus/bevy_atmosphere/actions/runs/4392830639/jobs/7692841809.2

@BrandonDyer64
Copy link
Contributor Author

Yeah I'll have a look

@BrandonDyer64
Copy link
Contributor Author

Would you prefer adding an exception to the deny file, or switching xml-rs to another crate, like quick-xml?

@Shatur
Copy link
Collaborator

Shatur commented Mar 11, 2023

Would you prefer adding an exception to the deny file, or switching xml-rs to another crate, like quick-xml?

I would add is as exception since it's used by winit.

@JonahPlusPlus
Copy link
Owner

Thank you for your work here. I had already started a 0.6 branch (#42), but I suppose if people really want a quick replacement we could make this the 0.6 version and release my update as 0.7.

@BrandonDyer64
Copy link
Contributor Author

BrandonDyer64 commented Mar 11, 2023

@JonahPlusPlus I like the idea of getting something in quick for Bevy 0.10 support, and having another update with all the goodies you've got in store for us at a later date. Many devs, like myself, are eager to start working with the new engine update, and would love to include bevy_atmosphere in their projects as soon as possible.

@Shatur Shatur requested a review from JonahPlusPlus March 11, 2023 23:58
@JonahPlusPlus
Copy link
Owner

Okay, I'll review and merge this, make some minor changes and it should be released later today or tomorrow.

Copy link
Owner

@JonahPlusPlus JonahPlusPlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

src/pipeline.rs Show resolved Hide resolved
@JonahPlusPlus JonahPlusPlus merged commit 4b8cfb8 into JonahPlusPlus:master Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants