Refactor build script for improved readability and maintainability #1163
Conversation
Consolidated common logic for loading suite, flavor, and board into a single load_config function. Reduced repetitive cd commands and improved error handling. Streamlined partial-build checks (kernel-only, rootfs-only, etc.) for early exits. Ensured original functionality remains intact while enhancing code clarity.
|
Thanks a lot for this. I will review this pr in a few days; I'm going through some stuff in my life and need some time to sort things out. |
Thank you for your contribution. This one of my favorite projects. Please take your time 🙏 |
| # Redirect all script output to a log file. | ||
| ####################################### | ||
| mkdir -p build/logs | ||
| exec > >(tee "build/logs/build-$(date +"%Y%m%d%H%M%S").log") 2>&1 |
There was a problem hiding this comment.
When using an Ubuntu 24.04 host machine this line will cause the script to exit early for some reason if one of the required parameters are not populated for a full build.
Below is an example, the script will exit as the log file is created, I have no idea why this happens.
$ sudo ./build.sh --suite=jammy --flavor=serverThere was a problem hiding this comment.
Interesting! I will take a look at it this weekend and see if I can resolve it. Thank you
Consolidated common logic for loading suite, flavor, and board into a single load_config function.
Reduced repetitive cd commands and improved error handling.
Streamlined partial-build checks (kernel-only, rootfs-only, etc.) for early exits.
Ensured original functionality remains intact while enhancing code clarity.