-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(require-name): add require-name rule #883
feat(require-name): add require-name rule #883
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #883 +/- ##
=======================================
Coverage 98.76% 98.77%
=======================================
Files 21 21
Lines 1219 1220 +1
Branches 142 142
=======================================
+ Hits 1204 1205 +1
Misses 15 15 ☔ View full report in Codecov by Sentry. |
8d3cbb0
to
a24436a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking up another so quickly! And nice work on the implementation. I just made one small request. Also, @chouchouji please start including the first two items in the PR template when you submit a PR. There's an existing issue for this that should be attached: #808 It helps keep things tidy in our backlog and will connect the PR and issue for additional context to our users. It would also be great to add a sentence or two (or more!) to the PR overview section.
a24436a
to
ad98a14
Compare
Sorry, I forget to link related issue. |
@michaelfaith Thanks for your review. I had fixed order. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks again
🎉 This is included in version v0.24.0 🎉 The release is available on: Cheers! 📦🚀 |
PR Checklist
status: accepting prs
Overview
Add
require-name
rule.