Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(require-name): add require-name rule #883

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

chouchouji
Copy link
Contributor

@chouchouji chouchouji commented Feb 8, 2025

PR Checklist

Overview

Add require-name rule.

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (8364668) to head (ad98a14).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #883   +/-   ##
=======================================
  Coverage   98.76%   98.77%           
=======================================
  Files          21       21           
  Lines        1219     1220    +1     
  Branches      142      142           
=======================================
+ Hits         1204     1205    +1     
  Misses         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@michaelfaith michaelfaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking up another so quickly! And nice work on the implementation. I just made one small request. Also, @chouchouji please start including the first two items in the PR template when you submit a PR. There's an existing issue for this that should be attached: #808 It helps keep things tidy in our backlog and will connect the PR and issue for additional context to our users. It would also be great to add a sentence or two (or more!) to the PR overview section.

@michaelfaith michaelfaith added the status: waiting for author Needs an action taken by the original poster label Feb 8, 2025
@chouchouji
Copy link
Contributor Author

Thanks for taking up another so quickly! And nice work on the implementation. I just made one small request. Also, @chouchouji please start including the first two items in the PR template when you submit a PR. There's an existing issue for this that should be attached: #808 It helps keep things tidy in our backlog and will connect the PR and issue for additional context to our users. It would also be great to add a sentence or two (or more!) to the PR overview section.

Sorry, I forget to link related issue.

@chouchouji
Copy link
Contributor Author

@michaelfaith Thanks for your review. I had fixed order.

@michaelfaith michaelfaith removed the status: waiting for author Needs an action taken by the original poster label Feb 8, 2025
Copy link
Collaborator

@michaelfaith michaelfaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks again

@michaelfaith michaelfaith merged commit 3a82dd8 into JoshuaKGoldberg:main Feb 8, 2025
19 of 21 checks passed
Copy link

github-actions bot commented Feb 8, 2025

🎉 This is included in version v0.24.0 🎉

The release is available on:

Cheers! 📦🚀

@chouchouji chouchouji deleted the feat-require-name branch February 9, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Bring in a require-name rule
2 participants