Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature2 tank movement #2

Open
wants to merge 3 commits into
base: JoystickAssetInclusion
Choose a base branch
from

Conversation

JoyJazper
Copy link
Owner

No description provided.

}
}

public Joystick tempJoystick;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be public. Change to private serialized field if you want to populate from inspector

@@ -1,11 +1,14 @@
using UnityEngine;
public class TankController
{
public TankController(TankModel initTankModel, TankView initTankView){
public TankController(TankModel initTankModel, TankView initTankView, Joystick tempStick){
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better variable names

Copy link

@kan15hk kan15hk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants