Allow choice of AD backend for conditions #80
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69
At the moment this works with default/adaptive backend and with
ForwardDiffBackend()
but not withZygoteBackend()
. I suspect this might be a bug in AbstractDifferentiation.jl (maybe AD#63). @mohamed82008 could you take a look? I skipped the problematic tests intest/systematic.jl
and marked them withTODO
.@thorek1 wanna take this branch out for a spin and see if it solves your problem?
This PR also changes the constructor syntax in a breaking way:
f
andc
are positional arguments, along withHandleByproduct()
, butlinear_solver
becomes a kwarg along with the newconditions_backend