Fix bugs with SparseInverseSubset on non-GPL Julia builds #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thought...would it be worth defining alternate methods for these rrules for non-GPL builds? I can imagine a case where someone writes code depending on them in an evironment where CHOLMOD is available, then tries to run it on a non-GPL build and gets surprising/mysterious errors. |
oxinabox
approved these changes
Jan 24, 2024
|
Lets see if anyone complains. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for #763: the code causing errors on non-GPL Julia builds is now wrapped in a conditional block, so it will never be executed if CHOLMOD is not available.