Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move LatentGP to AbstractGPs.jl #25

Merged
merged 4 commits into from
Jul 6, 2020
Merged

Move LatentGP to AbstractGPs.jl #25

merged 4 commits into from
Jul 6, 2020

Conversation

sharanry
Copy link
Contributor

@sharanry sharanry commented Jul 4, 2020

As discussed in LatentGPs#4, this PR moves LatentGP to AbstractGPs.jl.

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2020

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         9    +1     
  Lines          197       202    +5     
=========================================
+ Hits           197       202    +5     
Impacted Files Coverage Δ
src/AbstractGPs.jl 100.00% <ø> (ø)
src/latent_gp/latent_gp.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec5cf12...55d5c2e. Read the comment docs.

willtebbutt
willtebbutt previously approved these changes Jul 6, 2020
Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a patch-version bump. The refactoring can be done in a separate PR.

@sharanry sharanry merged commit ac4f85f into master Jul 6, 2020
@sharanry sharanry deleted the sharan/latent_gp branch July 6, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants