-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up and fix tests #125
Conversation
Pull Request Test Coverage Report for Build 7624664125Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
Yay, this works. I will include the other changes I made in #124 to clean things up. |
This reverts commit 5b3cc7d.
This is fantastic. Would you mind checking to see whether all of the upper bounds are actually necessary? I can definitely imagine that the Zygote / ChainRules ones are, but it seems surprising to be that it's necessary for e.g. |
That's what I was trying to avoid |
Ahh okay. No, I didn't see that thread. Could we at least try un-pinning AbstractGPs and KernelFunctions? I would be completely amazed if non-breaking changes in them actually break AD in TemporalGPs. |
Let's try |
This works. Let's then try removing some of the others. |
Ok, now I'm feeling bold. Let me push it a bit further. |
@willtebbutt ok, this is more of a minimal set of pinnings that works. |
I've had a look at the slack thread, but I'm not going to have a chance to dig into this for a while. I'm happy to approve this PR though |
Thanks. But I think if we merge this right now, perhaps we should put a note at the top of the README, that this package is currently pinning some AD deps and might hold back environments or cause conflicts. |
Another idea:
|
Checked out the registry at the time of the v0.6.5 release and then set the compat upper bounds to the resolved dependencies.
Supersedes #124