Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add equality operator for all structs. #41

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Add equality operator for all structs. #41

merged 1 commit into from
Jan 11, 2025

Conversation

evetion
Copy link
Member

@evetion evetion commented Jan 11, 2025

Encountered in GeoArrow testing of WKB equality (via GeoInterface testgeometry)

@evetion evetion requested a review from rafaqz January 11, 2025 00:27
Copy link
Member

@rafaqz rafaqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaqz rafaqz merged commit 17aa935 into master Jan 11, 2025
12 checks passed
@rafaqz rafaqz deleted the feat/equality branch January 11, 2025 12:06
@rafaqz
Copy link
Member

rafaqz commented Jan 11, 2025

Should we bump to 0.5 or 0.4.3 ?

@evetion
Copy link
Member Author

evetion commented Jan 11, 2025

This is not breaking I'd say? It's a bug fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants