-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation improvements + fixes #55
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asinghvi17
changed the title
Copy README to be the landing page for the docs
Documentation improvements + fixes
Feb 1, 2024
Looks like CI is failing on ExactPredicates.jl v2.2.7 (Julia 1.10) but not v2.2.5 (Julia 1.6) only when performing certain comparisons of test polygon
This is specifically with Testing Running tests...
Contains: Error During Test at /home/runner/work/GeometryOps.jl/GeometryOps.jl/test/methods/geom_relations.jl:170
Got exception outside of a @test
ArgumentError: `==` is only supported between thin intervals and numbers
Stacktrace:
[1] ==
@ ~/.julia/packages/IntervalArithmetic/rX8mD/src/intervals/real_interface.jl:149 [inlined]
[2] ==
@ ~/.julia/packages/IntervalArithmetic/rX8mD/src/intervals/real_interface.jl:155 [inlined]
[3] orient_slow(u::Tuple{Float64, Float64}, v::Tuple{Float64, Float64}, w::Tuple{Float64, Float64})
@ ExactPredicates ~/.julia/packages/ExactPredicates/p3E85/src/Codegen.jl:340
[4] orient
@ ~/.julia/packages/ExactPredicates/p3E85/src/Codegen.jl:470 [inlined]
[5] meet(p::Tuple{Float64, Float64}, q::Tuple{Float64, Float64}, a::Tuple{Float64, Float64}, b::Tuple{Float64, Float64})
@ ExactPredicates ~/.julia/packages/ExactPredicates/p3E85/src/plane.jl:113
[6] #_segment_segment_orientation#137
@ GeometryOps ~/work/GeometryOps.jl/GeometryOps.jl/src/methods/geom_relations/geom_geom_processors.jl:561 [inlined] and several others. The relevant tests are:
|
asinghvi17
requested review from
skygering and
rafaqz
and removed request for
skygering
February 3, 2024 22:07
Aha, I think they fixed this issue upstream in ExactPredicates. Should be good now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.