Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvements + fixes #55

Merged
merged 12 commits into from
Feb 7, 2024
Merged

Documentation improvements + fixes #55

merged 12 commits into from
Feb 7, 2024

Conversation

asinghvi17
Copy link
Member

No description provided.

@asinghvi17 asinghvi17 changed the title Copy README to be the landing page for the docs Documentation improvements + fixes Feb 1, 2024
@asinghvi17
Copy link
Member Author

asinghvi17 commented Feb 3, 2024

Looks like CI is failing on ExactPredicates.jl v2.2.7 (Julia 1.10) but not v2.2.5 (Julia 1.6) only when performing certain comparisons of test polygon p1 to itself:

↑ TEST INFO: p1 contains p1 - Same polygons
↑ TEST INFO: p1 coveredby p1 - Same polygons
↑ TEST INFO: p1 covers p1 - Same polygons
↑ TEST INFO: p1 within p1 - Same polygons

This is specifically with p1. None of the other polygons have any issues when self-comparing.

     Testing Running tests...
Contains: Error During Test at /home/runner/work/GeometryOps.jl/GeometryOps.jl/test/methods/geom_relations.jl:170
  Got exception outside of a @test
  ArgumentError: `==` is only supported between thin intervals and numbers
  Stacktrace:
    [1] ==
      @ ~/.julia/packages/IntervalArithmetic/rX8mD/src/intervals/real_interface.jl:149 [inlined]
    [2] ==
      @ ~/.julia/packages/IntervalArithmetic/rX8mD/src/intervals/real_interface.jl:155 [inlined]
    [3] orient_slow(u::Tuple{Float64, Float64}, v::Tuple{Float64, Float64}, w::Tuple{Float64, Float64})
      @ ExactPredicates ~/.julia/packages/ExactPredicates/p3E85/src/Codegen.jl:340
    [4] orient
      @ ~/.julia/packages/ExactPredicates/p3E85/src/Codegen.jl:470 [inlined]
    [5] meet(p::Tuple{Float64, Float64}, q::Tuple{Float64, Float64}, a::Tuple{Float64, Float64}, b::Tuple{Float64, Float64})
      @ ExactPredicates ~/.julia/packages/ExactPredicates/p3E85/src/plane.jl:113
    [6] #_segment_segment_orientation#137
      @ GeometryOps ~/work/GeometryOps.jl/GeometryOps.jl/src/methods/geom_relations/geom_geom_processors.jl:561 [inlined]

and several others. The relevant tests are:

 DE-9IM Geom Relations             |  562      4    566   7.7s
    Contains                        |   70      1     71   4.4s
    Covered By                      |   70      1     71   0.3s
    Covers                          |   70      1     71   0.3s
    Disjoint                        |   85            85   0.4s
    Intersect                       |   85            85   0.2s
    Touches                         |   85            85   0.3s
    Within                          |   70      1     71   0.3s
    Overlaps                        |   22            22   0.5s
    Crosses                         |    5             5   0.5s

@asinghvi17 asinghvi17 requested review from skygering and rafaqz and removed request for skygering February 3, 2024 22:07
@asinghvi17
Copy link
Member Author

Aha, I think they fixed this issue upstream in ExactPredicates. Should be good now!

@asinghvi17 asinghvi17 merged commit 84e9d53 into main Feb 7, 2024
4 checks passed
@asinghvi17 asinghvi17 deleted the as/readme-mainpage branch February 13, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant