Sg/cut poly #56
Sg/cut poly #56
Conversation
|
One thing I was wondering was if this should also have a Target field. To me, it seems intuitive that if you cut a polygon, you get a list of polygons. If you cut a multipolygon, you also get a list of polygons. The question is then how far would we want to extend something like this? If gets more confusing with cutting Linear Rings, for example as those would become LineStrings if cut, but stay as LinearRings if not cut. But I don't necessarily think we need to extend to curves... |
Co-authored-by: Anshul Singhvi <[email protected]>
|
@asinghvi17 I updated the docs. Any other feedback? |
src/methods/clipping/cut.jl
Outdated
| [[[5.0, 0.0], [10.0, 0.0], [10.0, 10.0], [5.0, 10.0], [5.0, 0.0]]] | ||
| ``` | ||
| """ | ||
| cut(geom, line::GI.Line, ::Type{T} = Float64) where {T <: AbstractFloat} = |
There was a problem hiding this comment.
Is there a reason to limit to GI.Line here?
There was a problem hiding this comment.
The algorithm only works with one line segment right now. I could also broaden to LineString and then throw an error if there is more than one non-collinear segment. That just seemed unnecessary right now.
There was a problem hiding this comment.
I mean it could also accept other Lines, like GeometryBasics
Using GI traits
There was a problem hiding this comment.
Oh yeah, you're right. Whoops. I will fix that.
|
I am going to merge this then now that I addressed those problems. Any final comments? |
I needed this functionality in my code and figured that it might be useful to other people. While it isn't a feature in GEOS, it is a feature in MATLAB with the function
cutpolygon. It also has quite a few similar posts on Stack Overflow. I was able to take advantage of the new clipping helper functions to write it. Hoping this isn't too specific.I also realized I made a type mistake in the clipping with the
Targetfield so I fixed that as well.