Clipping degeneracies #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sg/update intersects
…/GeometryOps.jl into sg_ll/clipping_degeneracies
…/GeometryOps.jl into sg_ll/clipping_degeneracies
…/GeometryOps.jl into sg_ll/clipping_degeneracies
asinghvi17
reviewed
Feb 29, 2024
|
I am going to merge this. I have other performance things I am working on and Lana is going to make some more degeneracy improvements, so there will be plenty of time to comment on it going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request handles degeneracies where the vertices of a polygon lie on the edges or vertices of the other polygon. These were implemented following the Foster 2019 paper.
The implementation in this pull request can still result in three types of "degeneracies": collinear points in the final polygon, a vertex appearing twice in the resulting polygon, and "glued edges" in the resulting polygon. We will deal with these cases in future pull requests. The issue of collinear points in the final polygon will most likely be dealt with in a post-processing step, while double vertices and glued edges can be addressed in the clipping algorithm by modifying the labelling of points. The ways in which we will address these degeneracies are discussed in the Foster paper.