WIP: Julia 0.7, remove globals, missing value, scale_offset #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work in progress that I started some time ago and unfortunately is not based on the last updates (eg. #59 , #55 etc.) This basically happened when I was working on the code anyway to do the julia 0.7 update and includes the following new features:
ncread
,ncwrite
etc) all close the file after the operation is finished. The NetCDF.open function gets ado
syntax to safely access files with the intermediate and array-like approach (see unit tests). This should make accessing the files more stablencread
andNetCDF.open
, so that the new Array{T,Missing} can be read and written to/from files, this is done without making a copy of the datascale_factor
andadd_offset
attributes and apply at least readvar in-place. The way to make this work without changing the data types is by letting the NetCDF library do the conversionI think this would fix the main concerns that were raised in #39
As I said, when I started this I did not foresee so much activity by other community members (thanks to @jmgnve ). I think one could either apply the last PRs #54 #57 #59 on top of this one. The problem is that I will offline for a few weeks and can only continue here end of July.
The other possibility would be to simply merge #59 and also do what @visr siggested JuliaGeo/meta#4 run nanosoldier to have a 0.7-compatible version as fast as possible. Then I would have to apply the changes proposed above. Let me know what you think, and if I don't reply, fell free to merge the other pull requests as needed.