Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svg issue 150 #249

Merged
merged 8 commits into from
Dec 19, 2022
Merged

Svg issue 150 #249

merged 8 commits into from
Dec 19, 2022

Conversation

oheil
Copy link
Contributor

@oheil oheil commented Dec 18, 2022

@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Base: 73.05% // Head: 73.24% // Increases project coverage by +0.19% 🎉

Coverage data is based on head (d9faff1) compared to base (a04b373).
Patch coverage: 98.43% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   73.05%   73.24%   +0.19%     
==========================================
  Files          32       32              
  Lines        6368     6436      +68     
==========================================
+ Hits         4652     4714      +62     
- Misses       1716     1722       +6     
Impacted Files Coverage Δ
src/drawings.jl 71.67% <98.43%> (+5.95%) ⬆️
src/Luxor.jl 75.00% <0.00%> (-25.00%) ⬇️
src/curves.jl 95.17% <0.00%> (-0.81%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oheil
Copy link
Contributor Author

oheil commented Dec 18, 2022

checking test/polysample.jl

Project.toml Outdated Show resolved Hide resolved
src/drawings.jl Outdated Show resolved Hide resolved
src/drawings.jl Show resolved Hide resolved
src/drawings.jl Outdated Show resolved Hide resolved
src/drawings.jl Outdated Show resolved Hide resolved
@cormullion cormullion merged commit 2105b3d into JuliaGraphics:master Dec 19, 2022
@cormullion
Copy link
Member

Let's give it a whirl! Thanks for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants